[PATCH] D102243: [DAGCombiner] Add test exposing bug in DAG combine.

[Hendrik Greving via Phabricator via llvm-commits]

hgreving added a comment.

In D102243#2751071 <https://reviews.llvm.org/D102243#2751071>, @hgreving wrote:

> In D102243#2751006 <https://reviews.llvm.org/D102243#2751006>, @spatel wrote:
>
>> In D102243#2750964 <https://reviews.llvm.org/D102243#2750964>, @hgreving wrote:
>>
>>> In D102243#2750702 <https://reviews.llvm.org/D102243#2750702>, @spatel wrote:
>>>
>>>> Is there some reason to not use scripted, auto-generated CHECK lines on this file?
>>>
>>> Would you mind hinting me to the script? I barely work upstream, sorry for that.
>>
>> No problem - it's in the repo at:
>> utils/update_llc_test_checks.py ( https://github.com/llvm/llvm-project/blob/main/llvm/utils/update_llc_test_checks.py )
>>
>> To run it, do something like this:
>> $ {path to}/update_llc_test_checks.py --llc={path to local}/llc dagcombine-dead-store.ll
>>
>> Then, you can just run that same command after applying D102096 <https://reviews.llvm.org/D102096> and rebuilding llc. No need to manually touch the test file unless it looks wrong/excessive.
>
> I had just found it a minute before this comment. Thanks. We can use this script downstream actually. Thanks for pointing it out.

Done.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102243/new/

https://reviews.llvm.org/D102243