[PATCH] D95443: IR/AArch64/X86: add "swifttailcc" calling convention.

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:196
 
-/// Returns the argument pop size.
-static uint64_t getArgumentPopSize(MachineFunction &MF,
-                                   MachineBasicBlock &MBB) {
+// Returns how much of the incoming argument stack area we should clean up in an
+// epilogue. For the C calling convention this will be 0, for guaranteed tail
----------------
jroelofs wrote:
> measured in bytes?
Should be a doxygen comment?


================
Comment at: llvm/lib/Target/AArch64/AArch64MachineFunctionInfo.h:57
 
+  // Space just below incoming stack pointer reserved for arguments being passed
+  // on the stack during a tail call. This will be the difference between the
----------------
This should be a Doxygen comment?


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64CallLowering.cpp:928
     MIB->getOperand(1).setImm(FPDiff);
-    CallSeqStart.addImm(NumBytes).addImm(0);
+    CallSeqStart.addImm(0).addImm(0);
     // End the call sequence *before* emitting the call. Normally, we would
----------------
Why did this change?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95443/new/

https://reviews.llvm.org/D95443