[PATCH] D101544: [AArch64][SVE] Improve sve.convert.to.svbool lowering

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm accepted this revision.
paulwalker-arm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/CodeGen/AArch64/sve-intrinsics-reinterpret.ll:86
+define <vscale x 16 x i1> @reinterpret_ptrue() {
+; Reinterpreting a ptrue should not introduce an `and` instruction.
+; CHECK-LABEL: reinterpret_ptrue:
----------------
Personally I see this as a function comment rather than belonging with the CHECK lines.


================
Comment at: llvm/test/CodeGen/AArch64/sve-intrinsics-reinterpret.ll:103
+; CHECK-NEXT:    ret
+  %1 = tail call <vscale x 8 x i1> @llvm.aarch64.sve.ptrue.nxv8i1(i32 31)
+  %2 = tail call <vscale x 8 x i1> @llvm.aarch64.sve.cmpgt.nxv8i16(<vscale x 8 x i1> %1, <vscale x 8 x i16> %a, <vscale x 8 x i16> %b)
----------------
You can simplify the test by passing `cmpgt`'s predicate as a function parameter.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101544/new/

https://reviews.llvm.org/D101544