[PATCH] D102204: [AArch64][GlobalISel] Support truncstorei8/i16 w/ combine to form truncating G_STOREs.

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 11 09:29:10 PDT 2021


paquette added inline comments.


================
Comment at: llvm/utils/TableGen/GlobalISelEmitter.cpp:3660
 
+  // Return the size of the MemoryVT in this predicate, if possible.
+  Optional<unsigned>
----------------
should probably be a doxygen comment


================
Comment at: llvm/utils/TableGen/GlobalISelEmitter.cpp:3784
+  // MMO's work in bytes so we must take care of unusual types like i1
+  // don't round down.
+  return llvm::alignTo(MemTyOrNone->get().getSizeInBits(), 8);
----------------
This comment is kind of confusing?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102204/new/

https://reviews.llvm.org/D102204



More information about the llvm-commits mailing list