[PATCH] D99055: [llvm-objcopy] Refactor CopyConfig structure.

[Alexey Lapshin via Phabricator via llvm-commits]

avl added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/llvm-objcopy.cpp:11
 #include "COFF/COFFObjcopy.h"
-#include "CopyConfig.h"
+#include "COFFConfig.h"
+#include "CommonConfig.h"
----------------
jhenderson wrote:
> avl wrote:
> > jhenderson wrote:
> > > Is there a particular reason you haven't put these files inside the COFF/ELF/MachO/wasm subdirectories?
> > They all supposed to go away from the llvm/tools/llvm-objcopy directory. They would be put into the include/llvm/Object/ObjCopy?  directory later. So I put it together for now. If it is necessary we might temporarily place them into COFF/ELF/MachO/wasm subdirectories until library review is not ready.
> I don't think it's particularly hard to move these headers once the code is pulled into a library at a later date. Given that there will be a presumed interim period when this patch will have landed, but the library does not exist yet, we should have everything make sense in the interim. That would imply the file format specific files should be in their corresponding subdirectories. After all, the files that are already in those directories will need to move too, right?
yes, that`s right. will put above into the specific directories.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99055/new/

https://reviews.llvm.org/D99055