[PATCH] D101538: [GlobalISel][IRTranslator] Make translate() methods virtual.
Aleksandr Bezzubikov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 11 08:58:38 PDT 2021
zuban32 added a comment.
In D101538#2745606 <https://reviews.llvm.org/D101538#2745606>, @aemerson wrote:
> Is this really necessary? Our preference is to use custom combines/lowering passes, or custom legalization, to do this.
Well, our usecase might not be that canonical, let me briefly explain. For example, translating a bitcast - default IRTranslator implementation turns it into a COPY when LLTs of src and dst are the same. In our target (SPIR-V) LLTs do not matter that much, the typeinfo is represented with some pseudo instructions. That's why losing a bitcast in the translator doesn't work for us.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101538/new/
https://reviews.llvm.org/D101538
More information about the llvm-commits
mailing list