[PATCH] D98276: [AsmParser][SystemZ][z/OS] Introducing HLASM Parser support to AsmParser - Part 1
    Anirudh Prasad via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Tue May 11 07:57:02 PDT 2021
    
    
  
anirudhp added inline comments.
================
Comment at: llvm/lib/MC/MCParser/AsmParser.cpp:2324
         OS << ", ";
-      Info.ParsedOperands[i]->print(OS);
+      Info.ParsedOperands[I]->print(OS);
     }
----------------
uweigand wrote:
> Here's some more spurious differences that should be removed.
clang-tidy complains that the variable `i` is lower case, when it should be upper case. Is it okay if we ignore clang-tidy in this case in favour of a more unchanged diff or vice-versa? I'm not sure which is preferred / more important.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98276/new/
https://reviews.llvm.org/D98276
    
    
More information about the llvm-commits
mailing list