[PATCH] D102155: [AIX][compiler-rt] Add scripts and cache file for building libatomic
Jinsong Ji via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 11 07:17:10 PDT 2021
jsji added a comment.
I like the part in `compiler-rt/lib/builtins/CMakeLists.txt` -- it is essentially the same principle of what we suggested yesterday -- make the code platform independent,
but I don't like the overall fact that we need to invoke `compiler-rt/utils/aix-install-libatomic.sh` as an additional step, and call cmake again...
I know CMake can NOT handle AIX archives well for now, I believe we can just implement that part using `ar` and add TODO to fix it once CMake support is ready.
What do you think?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102155/new/
https://reviews.llvm.org/D102155
More information about the llvm-commits
mailing list