[PATCH] D100684: [X86][CostModel] X86TTIImpl::getMemoryOpCost(): rewrite vector handling again

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 11 05:33:55 PDT 2021


lebedev.ri added a comment.

Thank you for the review!

In D100684#2750389 <https://reviews.llvm.org/D100684#2750389>, @RKSimon wrote:

> Mechanically I think its fine, I was trying to think of ways to clean it up as I don't think some of the code is as tidy as it could be, but we can iterate on that later on.

Yeah, the code isn't quite up to the quality i prefer, but i don't see any obvious cleanup opportunities right now.
I think, this might have issues with weird types (not powers-of-two / not byte-sized), but i'm not sure how much we support those..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100684/new/

https://reviews.llvm.org/D100684



More information about the llvm-commits mailing list