[PATCH] D101523: [DebugInfo] Fix updateDbgUsersToReg to support DBG_VALUE_LIST

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer added a comment.

In D101523#2750052 <https://reviews.llvm.org/D101523#2750052>, @jmorse wrote:

> Another question is what the old implementation of this did. Was it similarly borken?

You're exactly correct, this implementation has that flaw and the old one did as well. I think in most cases where we aren't using a full register, this doesn't matter because we're simply using the variable value directly, in which case the truncation to the variable size fixes this for us. There are some cases where this won't work however - such as if we have `DW_OP_minus` in the DWARF expression, in which case including the higher bits may result in an incorrect output. I'll open a bugzilla ticket about the issue, but since it exists before this patch I think the fix can come later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101523/new/

https://reviews.llvm.org/D101523