[PATCH] D102177: [AMDGPU][RFC] Improve sgpr function arguments

[Sebastian Neubauer via Phabricator via llvm-commits]

sebastian-ne added a comment.

In D102177#2750094 <https://reviews.llvm.org/D102177#2750094>, @madhur13490 wrote:

> In D102177#2748278 <https://reviews.llvm.org/D102177#2748278>, @arsenm wrote:
>
>> We have another proposal we were working on to rearrange these a bit differently. We need to account for a few more inputs in the layout
>
> As long as this remains in GFX land, we should be fine with it because our new proposal is for compute only (as of now).

I would like to keep the same calling convention in compute and graphics. At least regarding the stack pointer and others, because I don’t see a compelling reason to diverge even more. Actually, I’d like it if they were more common than they are now, because we implement some things twice at the moment.
The compute proposal should work just fine; if we move the stack and frame pointer, we end up with the same benefits as in this patch. I commented on the internal proposal for this (I hope I found the right one?).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102177/new/

https://reviews.llvm.org/D102177