[PATCH] D102215: [SelectionDAG] Propagate scoped AA metadata when lowering mem intrinsics.

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:5810-5813
+    AAMDNodes AAInfo;
+    I.getAAMetadata(AAInfo);
+    // Clear TBAA metadata.
+    AAInfo.TBAA = AAInfo.TBAAStruct = nullptr;
----------------
[nit] Maybe create a function to avoid repetition?


================
Comment at: llvm/test/CodeGen/AArch64/memcpy-scoped-aa.ll:1
+; RUN: llc -mtriple=aarch64-linux-gnu -o - %s | FileCheck %s
+
----------------
xbolva00 wrote:
> Precommit new tests?
I agree that would be nice to have them pre-commited and reflecting the old behavior so we can see the effect of this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102215/new/

https://reviews.llvm.org/D102215