[PATCH] D96883: Add support for JSON output style to llvm-symbolizer

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 11 02:20:38 PDT 2021


jhenderson added a comment.

Please make another commit to fix the unnecessary introduction of semi-colons in the places I've highlighted.



================
Comment at: llvm/include/llvm/DebugInfo/Symbolize/DIPrinter.h:39-40
 public:
   DIPrinter(){};
   virtual ~DIPrinter(){};
 
----------------
Why have these superfluous semi-colons reappeared?


================
Comment at: llvm/include/llvm/DebugInfo/Symbolize/DIPrinter.h:99-100
+
+  void listBegin() override{};
+  void listEnd() override{};
 };
----------------
Ditto.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96883/new/

https://reviews.llvm.org/D96883



More information about the llvm-commits mailing list