[PATCH] D96883: Add support for JSON output style to llvm-symbolizer
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 11 00:48:12 PDT 2021
jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
LGTM, with one nit.
================
Comment at: llvm/test/tools/llvm-symbolizer/output-style-json-frame.ll:1
+; This test checks JSON output for FRAME.
+
----------------
Nit: similar to the `##` in the other tests, use `;;` for comments in this test to help the comments stand out from lit and FileCheck directives.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96883/new/
https://reviews.llvm.org/D96883
More information about the llvm-commits
mailing list