[PATCH] D89177: [cmake] Add support for multiple distributions

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai marked 3 inline comments as done.
smeenai added inline comments.


================
Comment at: llvm/cmake/modules/LLVMDistributionSupport.cmake:39
+    # default (unnamed) distribution.
+    set_property(GLOBAL PROPERTY LLVM_DISTRIBUTION_FOR_${target} " ")
+  endforeach()
----------------
smeenai wrote:
> phosek wrote:
> > Can we use `EMPTY` or something along those lines to make it more obvious?
> Sure, I'll change it.
Thinking about this more, I prefer `DEFAULT` because it's marking the default (unnamed) distribution (and `<DEFAULT>` is just to make it stand out more and be less likely to clash with a user-specified distribution name). I can change it if you feel strongly though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89177/new/

https://reviews.llvm.org/D89177