[PATCH] D102210: [flang] Allow large and erroneous ac-implied-do's

[Pete Steinfeld via Phabricator via llvm-commits]

PeteSteinfeld created this revision.
PeteSteinfeld added a reviewer: klausler.
Herald added a reviewer: sscalpone.
PeteSteinfeld requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

We sometimes unroll an ac-implied-do of an array constructor into a flat list
of values.  We then re-analyze the array constructor that contains the
resulting list of expressions.  Such a list may or may not contain errors.

But when processing an array constructor with an unrolled ac-implied-do, the
compiler was building an expression to represent the extent of the resulting
array constructor containing the list of values.  The number of operands
in this extent expression was based on the number of elements in the
unrolled list of values.  For very large lists, this created an
expression so large that it could not be evaluated by the compiler
without overflowing the stack.

I fixed this by continuously folding the extent expression as each operand is
added to it.  I added the test .../flang/test/Semantics/array-constr-big.f90
that will cause the compiler to seg fault without this change.

Also, when the unrolled ac-implied-do expression contains errors, we were
repeating the same error message referencing the same source line for every
instance of the erroneous expression in the unrolled list.  This potentially
resulted in a very long list of messages for a single error in the source code.

I fixed this by comparing the message being emitted to the previously emitted
message.  If they are the same, I do not emit the message.  This change is also
tested by the new test array-constr-big.f90.

Several of the existing tests had duplicate error messages for the same source
line, and this change caused differences in their output.  So I adjusted the
tests to match the new message emitting behavior.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D102210

Files:
  flang/include/flang/Evaluate/shape.h
  flang/include/flang/Parser/message.h
  flang/lib/Parser/message.cpp
  flang/test/Semantics/allocate02.f90
  flang/test/Semantics/array-constr-big.f90
  flang/test/Semantics/io06.f90
  flang/test/Semantics/omp-atomic.f90
  flang/test/Semantics/omp-clause-validity01.f90
  flang/test/Semantics/omp-flush01.f90
  flang/test/Semantics/resolve70.f90

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102210.344273.patch
Type: text/x-patch
Size: 7195 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210511/3d64097e/attachment.bin>