[PATCH] D102207: [Debug-Info] make createAndAddDIE have dwarf::Tag type parameter - NFC

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 10 19:41:37 PDT 2021


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Looks good, thanks!



================
Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:279-280
   }
 
   return StringRef();
 }
----------------
You can remove this now.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:2047
   }
   llvm_unreachable("unexpected tag");
 }
----------------
You can remove this now


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102207/new/

https://reviews.llvm.org/D102207



More information about the llvm-commits mailing list