[PATCH] D100818: [lld-macho] Implement branch-range-extension thunks

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 10 17:19:49 PDT 2021


int3 added inline comments.


================
Comment at: lld/test/MachO/arm64-thunks.s:2
+# REQUIRES: aarch64, shell
+# UNSUPPORTED: windows
+
----------------
smeenai wrote:
> Is the `REQUIRES: shell` sufficient by itself, or do you also need the explicit `UNSUPPORTED: windows`?
It should be sufficient by itself. I believe they're largely the same thing as far as the buildbots are concerned, but `REQUIRES: shell` alone would be more semantically descriptive of what this test depends on in its current form


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100818/new/

https://reviews.llvm.org/D100818



More information about the llvm-commits mailing list