[PATCH] D102202: [WebAssembly] Add TLS data segment flag: WASM_SEG_FLAG_TLS

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 10 16:52:41 PDT 2021


sbc100 added inline comments.


================
Comment at: lld/test/wasm/tls.s:135
 
 # Expected body of tls1_addr:
 #   global.get 1
----------------
dschuff wrote:
> I know this is just an explanatory comment, but should these names match the names above?
Good catch.   The names don't matter to the test because we are testing that they get merged, but yes that is a typo.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102202/new/

https://reviews.llvm.org/D102202



More information about the llvm-commits mailing list