[PATCH] D98081: [AMDGPU] Improve Codegen for build_vector

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 10 16:09:56 PDT 2021


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with test nit



================
Comment at: llvm/test/CodeGen/AMDGPU/v_pack.ll:7
+
+define amdgpu_kernel void @v_pack_b32_v2half(half addrspace(1)* %in0, half addrspace(1)* %in1) #0 {
+; GCN-LABEL: v_pack_b32_v2half:
----------------
s/v2half/v2f16 for consistency


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98081/new/

https://reviews.llvm.org/D98081



More information about the llvm-commits mailing list