[PATCH] D102201: [IR][AutoUpgrade] Drop align attribute from void return types

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.

LGTM with a couple of nits about the test.



================
Comment at: llvm/test/Bitcode/upgrade-void-ret-attr.ll:1
+;; Check upgrade is removing the incompatible attributes on void type from old bitcode
+
----------------
Please add a period at the end of the sentence. Also, I'm not sure we need the `;;`, one is probably fine.


================
Comment at: llvm/test/Bitcode/upgrade-void-ret-attr.ll:3
+
+; RUN: llvm-dis < %S/upgrade-void-ret-attr.bc | FileCheck %s
+
----------------
For the bitcode file, I suggest using `%s.bc` (meaning the extension is `.ll.bc`), to simplify this.

Also, please rename the `.ll` file to end with the released version of LLVM used to generate the bitcode (e.g., `-10.0.ll`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102201/new/

https://reviews.llvm.org/D102201