[PATCH] D101996: [LLD] Improve reporting unresolved symbols in shared libraries

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/ELF/InputFiles.h:388
+  // Non-weak undefined symbols which are not yet resolved when the SO is
+  // parsed. Only filled if we check unresolved symbols in shared libraries,
+  // i.e. (config->unresolvedSymbolsInShlib != UnresolvedPolicy::Ignore).
----------------
ikudrin wrote:
> MaskRay wrote:
> > MaskRay wrote:
> > > Perhaps simply this to `--no-allow-shlib-undefined`
> > Drop `and alike`? There is no other usage.
> It's about `--unresolved_symbols=ignore-in-object-files` and `--unresolved_symbols=report-all`. The implementation is the same, but the switches are still different.
To the best of my knowledge, no project uses ignore-in-object-files or report-all. Intentionally we just translate them to --no-allow-shlib-undefined. I do slightly prefer dropping `and alike`, but am fine if you want to keep it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101996/new/

https://reviews.llvm.org/D101996