[PATCH] D97598: [NFC][AMDGPU] Document the AMDGPU target feature defaults

Artem Belevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 10 14:28:07 PDT 2021


tra added inline comments.


================
Comment at: llvm/docs/AMDGPUUsage.rst:484-485
      sramecc         - ``-mcpu``                  If specified, generate code that can only be
                      - ``--offload-arch``         loaded and executed in a process that has a
                                                   matching setting for SRAMECC.
 
----------------
@t-tye:  What does it mean for the **process** to have SRAMECC (or XNACK) setting ?

The description of the target features implies that SRAMECC/XNACK are properties of the hardware, so I suspect it's a typo.
Is it supposed to be `executed on a processor` instead? 

If the features are indeed something that's specific for particular GPU, 
are there any tools/or docs which would tell me which particular set of features is needed for the GPU I have? 
What determines the specific on/off values for the features? GPU's BIOS?

E.g. gfx908 lists `sramecc` and `xnack` as supported, but does not tell me which specific combination of them I need to use to build for a MI100 GPU.
For older GPUs, the fixed feature set described for object V2 provided useful list of the features, but it does not include newer GPUs.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97598/new/

https://reviews.llvm.org/D97598



More information about the llvm-commits mailing list