[PATCH] D100257: [VPlan] Add VPUserID to distinguish between recipes and others.

[Florian Hahn via Phabricator via llvm-commits]

fhahn updated this revision to Diff 344192.
fhahn added a comment.

Update to make getVPUserID() and the ID enum public, make constructors protected and remove static assert.

In D100257#2747524 <https://reviews.llvm.org/D100257#2747524>, @gilr wrote:

>> Thanks, I updated the code to turn VPUser in a virtual base class and added s subclass for the uses in VPBlockBase. WDYT?
>> (For now I used a dummy function VPUser::makeVPUserVirtual to turn VPUser into a pure virtual class. Not sure if there's a different way?)
>
> Wouldn't making the constructors protected suffice?

Yeah, I guess we do not need it to be pure virtual, updated!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100257/new/

https://reviews.llvm.org/D100257

Files:
  llvm/lib/Transforms/Vectorize/VPlan.cpp
  llvm/lib/Transforms/Vectorize/VPlan.h
  llvm/lib/Transforms/Vectorize/VPlanValue.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D100257.344192.patch
Type: text/x-patch
Size: 6929 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210510/6df965d9/attachment-0001.bin>