[PATCH] D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing

[Digger Lin via Phabricator via llvm-commits]

DiggerLin added inline comments.


================
Comment at: llvm/tools/llvm-readobj/XCOFFDumper.cpp:185
+  if (Obj.is64Bit()) {
+    if (AuxEntPtr->AuxType != XCOFF::AUX_FILE)
+      W.startLine() << "!Mismatched auxiliary type: ";
----------------
if (AuxEntPtr->AuxType != XCOFF::AUX_FILE ) , it should not be parsed as 
XCOFF::AUX_FILE
it may better to print out raw data  in the printSymbol()


================
Comment at: llvm/tools/llvm-readobj/XCOFFDumper.cpp:233
+    W.printEnum("Auxiliary Type", static_cast<uint8_t>(AuxType),
+                makeArrayRef(SymAuxType));
+  } else {
----------------
if (AuxEntPtr->AuxType != XCOFF::AUX_CSECT) , it should not be parsed as
XCOFF::AUX_CSECT  above
it may better to print out raw data in the printSymbol()


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85774/new/

https://reviews.llvm.org/D85774