[PATCH] D93927: [ArgPromotion] Copy !range metadata for loads.

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/ArgumentPromotion.cpp:316
+          BasicBlock *BB = OrigLoad->getParent();
+          if (BB == &BB->getParent()->getEntryBlock()) {
+            // Transfer the AA info too.
----------------
Without taking a closer look at the overall patch, this check is insufficient, because not all instructions in the entry block are guaranteed to execute (e.g. due to unwinding). There is isGuaranteedToTransferExecutionToSuccessor to check this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93927/new/

https://reviews.llvm.org/D93927