[PATCH] D97657: [lld][WebAssembly] Initial support merging string data
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 10 10:24:05 PDT 2021
sbc100 added inline comments.
================
Comment at: lld/wasm/InputChunks.cpp:374
+ return ms->parent->getOffset(ms->getParentOffset(offset));
+ return ms->getParentOffset(offset);
+ }
----------------
dschuff wrote:
> dschuff wrote:
> > This is dead because of the assertion above.
> This comment still stands (the else cases is dead, right?)
You are right.. for some reason the ELF code seem have code to handle the case when the parent is null.. but I don't see how that could ever happen, and least with wasm code.. removed the condition.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97657/new/
https://reviews.llvm.org/D97657
More information about the llvm-commits
mailing list