[PATCH] D102155: [AIX][compiler-rt] Add cmake module to build libatomic.a

David Tenty via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 10 09:56:11 PDT 2021


daltenty added inline comments.


================
Comment at: compiler-rt/lib/builtins/CMakeLists.txt:751
+# On AIX, we have to ship a libatomic.a for compatibility.
+if (${CMAKE_SYSTEM_NAME} MATCHES "AIX")
+  include(CompilerRTAIXUtils)
----------------
Maybe a more generic CMake option (e.g. `COMPILER_RT_BUILD_LIBATOMIC`) with an appropriate default for AIX would be better here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102155/new/

https://reviews.llvm.org/D102155



More information about the llvm-commits mailing list