[PATCH] D102131: [polly] In IslNodeBuilder::createMark() use isl::noexception bindings [NFC]

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 10 09:21:22 PDT 2021


Meinersbur added inline comments.


================
Comment at: polly/lib/CodeGen/IslNodeBuilder.cpp:408
+void IslNodeBuilder::createMark(isl::ast_node Node) {
+  auto *Id = isl_ast_node_mark_get_id(Node.get());
+  auto *Child = isl_ast_node_mark_get_node(Node.get());
----------------
With the argument now being out smart pointer, we prefer using its accessor methods.


================
Comment at: polly/lib/CodeGen/IslNodeBuilder.cpp:409
+  auto *Id = isl_ast_node_mark_get_id(Node.get());
+  auto *Child = isl_ast_node_mark_get_node(Node.get());
+
----------------
same here


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102131/new/

https://reviews.llvm.org/D102131



More information about the llvm-commits mailing list