[PATCH] D102128: [polly] In IslNodeBuilder::createIf() use isl::noexception bindings [NFC]

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 10 09:18:33 PDT 2021


Meinersbur added inline comments.


================
Comment at: polly/lib/CodeGen/IslNodeBuilder.cpp:836
 
-  create(isl_ast_node_if_get_then(If));
+  create(isl_ast_node_if_get_then(If.get()));
 
----------------
 With `isl::ast_node`, we prefer using its accessor methods over calling the C API.


================
Comment at: polly/lib/CodeGen/IslNodeBuilder.cpp:840-841
 
-  if (isl_ast_node_if_has_else(If))
-    create(isl_ast_node_if_get_else(If));
+  if (isl_ast_node_if_has_else(If.get()))
+    create(isl_ast_node_if_get_else(If.get()));
 
----------------
same here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102128/new/

https://reviews.llvm.org/D102128



More information about the llvm-commits mailing list