[PATCH] D102129: [polly] In IslNodeBuilder::addParameters() use isl::noexception bindings [NFC]

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 10 09:12:47 PDT 2021


Meinersbur added inline comments.


================
Comment at: polly/lib/CodeGen/CodeGeneration.cpp:270
   } else {
-    NodeBuilder.addParameters(S.getContext().release());
+    NodeBuilder.addParameters(isl::manage(S.getContext().release()));
     Value *RTC = NodeBuilder.createRTC(AI.getRunCondition().release());
----------------
`manage( .release())` is redundant: `release()` removes the smart pointer just for `manage()` to put it into into a new one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102129/new/

https://reviews.llvm.org/D102129



More information about the llvm-commits mailing list