[PATCH] D102096: [DAGCombiner] Fix DAG combine store elimination, different address space.

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 10 08:57:52 PDT 2021


spatel added a comment.

In D102096#2747980 <https://reviews.llvm.org/D102096#2747980>, @spatel wrote:

> In D102096#2747951 <https://reviews.llvm.org/D102096#2747951>, @hgreving wrote:
>
>> In D102096#2747115 <https://reviews.llvm.org/D102096#2747115>, @xbolva00 wrote:
>>
>>> What about DeadStoreElimination ? It can also merge stores.. maybe dse needs similar fix.
>>
>> https://www.godbolt.org/z/aqncWfb4c seems to suggest maybe, though haven't debugged whether it's DSE or DAG combine again who does it.
>
> If you show the IR for that example, it looks ok:
> https://www.godbolt.org/z/55v7anfa3

Can you add that example to the test file and commit that file as a preliminary step?
Please use "utils/update_llc_test_checks.py" if possible to auto-generate the FileCheck lines.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102096/new/

https://reviews.llvm.org/D102096



More information about the llvm-commits mailing list