[PATCH] D100523: [lld][MachO] Add support for LC_VERSION_MIN_* load commands

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 10 07:55:36 PDT 2021


thakis added inline comments.


================
Comment at: lld/MachO/InputFiles.cpp:154
+  }
+  if (platformInfo->minimum >= config->platformInfo.minimum)
+    return true;
----------------
int3 wrote:
> thakis wrote:
> > Should this just be `<=`? An .o file is compatible if it targets an older or at most as new platform as the output, right?
> welp, I believe you're right
(fixed here https://reviews.llvm.org/D101114 )


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100523/new/

https://reviews.llvm.org/D100523



More information about the llvm-commits mailing list