[PATCH] D101900: [InstCombine] Fold extractelement + vector GEP with one use

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/vec_demanded_elts-inseltpoison.ll:502
 
 ;; TODO: getelementptr tests below show missing simplifications for
 ;; vector demanded elements on vector geps.
----------------
Remove stale comment.


================
Comment at: llvm/test/Transforms/InstCombine/vec_demanded_elts-inseltpoison.ll:511
 ;
   %gep = getelementptr i32, <2 x i32*> %base, i64 1
   %ee = extractelement <2 x i32*> %gep, i32 1
----------------
IIUC, this is 1 of the 2 basic patterns that we want to transform. 

It would be better to use different index values in the test though, so we can verify that the indexes are being translated as expected (for example, make the gep index an argument variable?).

If that is a good suggestion, please commit the test change as a preliminary patch (no review needed), so we just see the functional diff from this patch here.


================
Comment at: llvm/test/Transforms/InstCombine/vec_demanded_elts.ll:511
 ;
   %gep = getelementptr i32, <2 x i32*> %base, i64 1
   %ee = extractelement <2 x i32*> %gep, i32 1
----------------
This test file is the pre-poison equivalent of the other one, so see earlier test comments.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101900/new/

https://reviews.llvm.org/D101900