[PATCH] D101025: [llvm-dwarfdump] Fix abstract origin vars location stats calculation

Mon May 10 03:04:21 PDT 2021

djtodoro added a comment.

In D101025#2727098 <https://reviews.llvm.org/D101025#2727098>, @dblaikie wrote:

> Sorry, I know this is annoying - but could you commit the renaming as a separate preliminary patch (feel free to commit that without review)? It'd make it much easier to understand the semantic change in this patch with that separated.

(Sorry for delay, I was on PTO.)

It makes sense to me, I'll do that ASAP.

================
Comment at: llvm/tools/llvm-dwarfdump/Statistics.cpp:225-226
+static void
+collectStatsForDie(DWARFDie Die, std::string FnPrefix, std::string VarPrefix,
+                   uint64_t BytesInScope, uint32_t InlineDepth,
+                   StringMap<PerFunctionStats> &FnStatMap,
----------------
dblaikie wrote:
> Side note: why are we passing around std::strings by value? Should these be being passed by const ref? 
I think we should be using const ref instead.
But it is existing code, and the change for that should be a separate commit, right?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101025/new/

https://reviews.llvm.org/D101025