[PATCH] D102142: [Demangle][Rust] Parse basic types
Tomasz Miąsko via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 10 02:59:53 PDT 2021
tmiasko updated this revision to Diff 344011.
tmiasko marked 2 inline comments as done.
tmiasko added a comment.
Address review comments
- Add description of <basic-type> production from the specification.
- Don't use else after a return.
The other rules seems equally good for testing <type> as <generic-arg> is, so I left this as is.
Could you commit this for me? Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102142/new/
https://reviews.llvm.org/D102142
Files:
llvm/include/llvm/Demangle/RustDemangle.h
llvm/lib/Demangle/RustDemangle.cpp
llvm/test/Demangle/rust.test
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102142.344011.patch
Type: text/x-patch
Size: 5068 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210510/554ce492/attachment.bin>
More information about the llvm-commits
mailing list