[PATCH] D102080: [ORC-RT] Add unit test infrastructure, extensible_rtti implementation, unit test

Mon May 10 01:59:58 PDT 2021

sgraenitz added a subscriber: kubamracek.
sgraenitz added a comment.

In D102080#2744882 <https://reviews.llvm.org/D102080#2744882>, @lhames wrote:

> We're already building runtime libraries, but in the tests it looks like we're building a parallel archive for the runtime and writing it to the test directory for the tests to link against. Is there a reason the tests can't just link against the built runtimes?

I think on Apple platforms TSAN only builds a dylib for production [1]. Tests should link statically so it's building a static archive for this case. All other Unix platforms do the opposite. Not sure why, but at least it looks consistent. There's a related comment about that in [2]. Maybe @kubamracek can tell you more :)

The ORC runtime is a static archive in any case right? So I guess this won't apply here. (Disclaimer: not a compiler-rt expert)

[1] https://github.com/llvm/llvm-project/blob/a81e45b8bcb8eb274ad73357e10e2cdf8a314a8c/compiler-rt/lib/tsan/CMakeLists.txt#L140
[2] https://github.com/llvm/llvm-project/blob/c47620a838eae330c04453ed3900aab0ac4159cb/compiler-rt/lib/tsan/tests/CMakeLists.txt#L71

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102080/new/

https://reviews.llvm.org/D102080