[PATCH] D99173: Intrinsic::getName: require a Module argument

[Jeroen Dobbelaere via Phabricator via llvm-commits]

jeroen.dobbelaere added a comment.

Other possible alternative names:

- `LLVMIntrinsicCopyOverloadedNameSupportingUnnamedTypes`: maybe too long ?
- `LLVMIntrinsicCopyOverloadedNameWithModule` : the WithModule part is strange
- `LLVMIntrinsicCopyOverloadedName2` : feels most natural to me: we needed to update the signature, but the functionality is still the same.

My current preference is still `LLVMIntrinsicCopyOverloadedName2`, although the `LLVMIntrinsicCopyOverloadedNameSupportingUnnamedTypes` also sounds ok.

What do you think ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99173/new/

https://reviews.llvm.org/D99173