[PATCH] D102145: [Coroutines] Add `llvm.coro.align` and `llvm.coro.raw.frame.ptr.offset` intrinsics

[Chuanqi Xu via Phabricator via llvm-commits]

ChuanqiXu added a comment.

The overall patch looks good to me. It seems like this patch did nothing without D97915 <https://reviews.llvm.org/D97915>. And it is different from normal NFC changes. I am not sure if it is more proper to merge this with D97915 <https://reviews.llvm.org/D97915>.



================
Comment at: llvm/lib/Transforms/Coroutines/CoroSplit.cpp:1059
+    auto *FramePtrOffset = ConstantInt::get(
+        Intrin->getType(), Shape.SwitchLowering.FramePtrOffset);
+
----------------
It looks like Shape.SwitchLowering.FramePtrOffset is used but never set other than initializing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102145/new/

https://reviews.llvm.org/D102145