[PATCH] D102143: [lld-macho] Treat an undefined entry symbol like any other undefined

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 9 18:17:45 PDT 2021


thakis added inline comments.


================
Comment at: lld/MachO/Driver.cpp:1143
     // via -u flag twice.
     for (const Symbol *undefined : config->explicitUndefineds) {
       if (isa<Undefined>(undefined)) {
----------------
I think this needs basically the same change. `-u _foo -undefined dynamic_lookup` forces a dynamically-looked-up symbol `foo` to exist at load time with ld64. (Can't really think of a use case for that either, but since it's next to the entry point right now and behaves the same way right now, this should probably receive the same treatment in this change.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102143/new/

https://reviews.llvm.org/D102143



More information about the llvm-commits mailing list