[lld] 7b6dd26 - [lld/mac] Copy some of the commit message of d5a70db193 into a comment

Nico Weber via llvm-commits llvm-commits at lists.llvm.org
Sat May 8 10:03:30 PDT 2021


Author: Nico Weber
Date: 2021-05-08T13:03:17-04:00
New Revision: 7b6dd265ce8320fee8741ec86edae5d40d7b7b86

URL: https://github.com/llvm/llvm-project/commit/7b6dd265ce8320fee8741ec86edae5d40d7b7b86
DIFF: https://github.com/llvm/llvm-project/commit/7b6dd265ce8320fee8741ec86edae5d40d7b7b86.diff

LOG: [lld/mac] Copy some of the commit message of d5a70db193 into a comment

Added: 
    

Modified: 
    lld/MachO/UnwindInfoSection.cpp

Removed: 
    


################################################################################
diff  --git a/lld/MachO/UnwindInfoSection.cpp b/lld/MachO/UnwindInfoSection.cpp
index 76502bfb82bca..a9f0bbd555014 100644
--- a/lld/MachO/UnwindInfoSection.cpp
+++ b/lld/MachO/UnwindInfoSection.cpp
@@ -306,6 +306,9 @@ template <class Ptr> void UnwindInfoSectionImpl<Ptr>::finalize() {
 
   // Dead-stripped functions get a functionAddress of UINT64_MAX in
   // relocateCompactUnwind(). Filter them out here.
+  // FIXME: This doesn't yet collect associated data like LSDAs kept
+  // alive only by a now-removed CompactUnwindEntry or other comdat-like
+  // data (`kindNoneGroupSubordinate*` in ld64).
   CompactUnwindEntry<Ptr> tombstone;
   tombstone.functionAddress = static_cast<Ptr>(UINT64_MAX);
   cuPtrVector.erase(


        


More information about the llvm-commits mailing list