[PATCH] D99784: [LICM] Hoist loads with invariant.group metadata

Sat May 8 05:46:54 PDT 2021

lebedev.ri reopened this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

Hello. I have just reverted this in rG1acd9a1a29ac30044ecefb6613485d5d168f66ca <https://reviews.llvm.org/rG1acd9a1a29ac30044ecefb6613485d5d168f66ca>,
as it bisected to be the first bad commit for a crash.

This appears to miscompile google benchmark's GetCacheSizesFromKVFS()
when compiling with -fstrict-vtable-pointers.
Runnable reproducer: https://godbolt.org/z/f9ovKqTzb
The "f.fail()" crashes with BUS error, it is compiled into testb,
and the address it is testing is non-sensical.

Please let me know if you are having issues reproducing.
I don't believe this is UB in source code, at least i don't see it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99784/new/

https://reviews.llvm.org/D99784