[PATCH] D102100: [lld-macho] Explicitly undefine literal exported symbols

[Jez Ng via Phabricator via llvm-commits]

int3 added a comment.

Thanks!



================
Comment at: lld/test/MachO/export-options.s:3
 
 # RUN: split-file %s %t
 # RUN: llvm-mc -filetype=obj -triple=x86_64-apple-macos %t/default.s -o %t/default.o
----------------
to make sure we aren't adding to the same archive multiple times


================
Comment at: lld/test/MachO/export-options.s:64-91
 ## Check that the export trie is unaltered
 # RUN: %lld -dylib %t/default.o -o %t/default
 # RUN: llvm-objdump --macho --exports-trie %t/default | \
 # RUN:     FileCheck --check-prefix=DEFAULT %s
 
 # DEFAULT-LABEL: Exports trie:
 # DEFAULT-DAG:   _hide_globl
----------------
I know this is existing code, but it seems kind of odd to me that the CHECK / RUN lines are below instead of above the test inputs


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102100/new/

https://reviews.llvm.org/D102100