[llvm] d319005 - lit: revert 134b103fc0f3a995d76398bf4b029d72bebe8162

Arthur Eubanks via llvm-commits llvm-commits at lists.llvm.org
Fri May 7 18:10:56 PDT 2021


I had to revert this, it was causing issues and lit was hanging (see the
revert commit message).
With some testing, bumping it up to 61 repros my issue, but 60 is fine.
I'll submit a change to bump it up to 60, hopefully that works for you (and
nobody else sees issues like mine).

On Fri, May 7, 2021 at 10:23 AM Saleem Abdulrasool via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

>
> Author: Saleem Abdulrasool
> Date: 2021-05-07T10:22:43-07:00
> New Revision: d319005a3746a7661c8c9a3302266b6ff7cf61be
>
> URL:
> https://github.com/llvm/llvm-project/commit/d319005a3746a7661c8c9a3302266b6ff7cf61be
> DIFF:
> https://github.com/llvm/llvm-project/commit/d319005a3746a7661c8c9a3302266b6ff7cf61be.diff
>
> LOG: lit: revert 134b103fc0f3a995d76398bf4b029d72bebe8162
>
> Revert the 32-process cap on Windows.  When testing with Swift, we found
> that there was a time reduction for testing with the higher load.  This
> should hopefully not matter much in practice.  In the case that the
> original problem with python remains with a high subprocess count, we
> can easily revert this change.
>
> Added:
>
>
> Modified:
>     llvm/utils/lit/lit/util.py
>
> Removed:
>
>
>
>
> ################################################################################
> diff  --git a/llvm/utils/lit/lit/util.py b/llvm/utils/lit/lit/util.py
> index 0d8f0040f41cc..fb96b2238b891 100644
> --- a/llvm/utils/lit/lit/util.py
> +++ b/llvm/utils/lit/lit/util.py
> @@ -119,12 +119,6 @@ def usable_core_count():
>          n = len(os.sched_getaffinity(0))
>      except AttributeError:
>          n = os.cpu_count() or 1
> -
> -    # On Windows, with more than 32 processes, process creation often
> fails with
> -    # "Too many open files".  FIXME: Check if there's a better fix.
> -    if platform.system() == 'Windows':
> -        return min(n, 32)
> -
>      return n
>
>
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210507/bc4fd957/attachment.html>


More information about the llvm-commits mailing list