[PATCH] D101923: [TableGen] Make the NUL character invalid in .td files

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 7 17:19:41 PDT 2021


dblaikie added a comment.

In D101923#2745614 <https://reviews.llvm.org/D101923#2745614>, @Paul-C-Anagnostopoulos wrote:

> No, I was confused, thinking that the modified file would go back through Lit. But of course it doesn't. I will set up something like you suggest. I'm sure there is a way to use an escape sequence to represent the NUL character in sed . . . yes, \000.
>
> First I have to get sed for Windows.

How does the existing sed test work on your machine? Or is the test flagged as "REQUIRES: shell" and so is unsupported on your system? (in which case getting sed won't be enough to make the test run, perhaps?)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101923/new/

https://reviews.llvm.org/D101923



More information about the llvm-commits mailing list