[PATCH] D101782: [AArch64][GlobalISel] Add post-legalizer lowering for NEON vector fcmps

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64PostLegalizerLowering.cpp:947
+  MIB.setInstrAndDebugLoc(MI);
+  auto Cmp = getVectorFCMP(CC, LHS, RHS, IsZero, NoNans, MRI);
+  if (!Cmp)
----------------
aemerson wrote:
> When can this be None? Is there missing support that needs to be added later, or should this be more of an assert?
Yeah, actually, I couldn't find any place where this actually makes sense in SDAG after a second look. This can probably all be simpler.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101782/new/

https://reviews.llvm.org/D101782