[PATCH] D101923: [TableGen] Make the NUL character invalid in .td files

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 7 16:49:01 PDT 2021


dblaikie added a comment.

In D101923#2745590 <https://reviews.llvm.org/D101923#2745590>, @Paul-C-Anagnostopoulos wrote:

> There are test files that use sed to do replacements. I'll ask on llvm dev how to create a RUN: line that does the right thing. It has to replace @ with NUL //and// get rid of the sed command so it doesn't recurse forever. My Unix command knowledge is meager.

Sorry, I missed the second step - why would it need to get rid of the sed command?

I'd expect something like:

  ; RUN: sed -e 's/@/NUL/g' %s > %t.input
  ; RUN: llvm-tblgen %t.input | FileCheck
  
  Stuff @ more stuff

Oh, you mean the problem that the sed line itself would get replaced - then there'd be a null character in the RUN line? Maybe you can strip that off with `head -n +1` or something like that?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101923/new/

https://reviews.llvm.org/D101923



More information about the llvm-commits mailing list