[PATCH] D101923: [TableGen] Make the NUL character invalid in .td files

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D101923#2745551 <https://reviews.llvm.org/D101923#2745551>, @Paul-C-Anagnostopoulos wrote:

> There are four or five NULs in the test file, to check them in various positions. Would it be helpful to add a second nul-char.txt file that is a duplicate, except that it has an at sign (@) where every null is? I could refer to it with a comment in nul-char.td.

Maybe? But could you look around at other tests, see if maybe there's a way to construct this test while having it still be a single text file? I'm wondering if any existing tests use the unix `tr` program or something to do specific replacements.

If there's no reasonable way to make this test work as a text file - maybe it'll be best to include the binary file and then a separate text file with the RUN/CHECK lines - and, yeah, maybe it'd be alright/good to include the text of the binary file with @ instead of null where the nulls would be as the text inside the RUN/CHECK file.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101923/new/

https://reviews.llvm.org/D101923