[PATCH] D101835: [llvm] llvm-tapi-diff

[Sam Powell via Phabricator via llvm-commits]

spowell updated this revision to Diff 343764.
spowell added a comment.

changed getTargetTriple to getTargetTripleName; fixed header descriptions; fixed unreachable path; return const reference from getInterfaceFile; passing Target as const reference into getTargetTripleName; added llvm_unreachable to getOSAndEnvironmentName; NOT -> not in tests; removed unnecessary comparison in checkSymbolEquality; refactored typenames for addValToDiffVec template function; added Doxygen comments for DiffEngine.h; One and Two => LHS and RHS in llvm-tapi-diff; added WithColor; return llvm::Error or std::unique_ptr<Binary> for convertFileToBinary instead of only dumping error; used EXIT_FAILURE instead of returning 1;


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101835/new/

https://reviews.llvm.org/D101835

Files:
  llvm/include/llvm/Object/TapiUniversal.h
  llvm/include/llvm/TextAPI/Platform.h
  llvm/include/llvm/TextAPI/Symbol.h
  llvm/include/llvm/TextAPI/Target.h
  llvm/lib/TextAPI/Platform.cpp
  llvm/lib/TextAPI/Target.cpp
  llvm/test/tools/llvm-tapi-diff/Inputs/v4A.tbd
  llvm/test/tools/llvm-tapi-diff/Inputs/v4B.tbd
  llvm/test/tools/llvm-tapi-diff/Inputs/v4C.tbd
  llvm/test/tools/llvm-tapi-diff/Inputs/v4D.tbd
  llvm/test/tools/llvm-tapi-diff/Inputs/v4E.tbd
  llvm/test/tools/llvm-tapi-diff/tapi-diff-matching-tbd.test
  llvm/test/tools/llvm-tapi-diff/tapi-diff-mismatched-number-of-inlines.test
  llvm/test/tools/llvm-tapi-diff/tapi-diff-no-inlines.test
  llvm/test/tools/llvm-tapi-diff/tapi-diff-same-number-of-inlines.test
  llvm/test/tools/llvm-tapi-diff/tapi-diff-tbd-has-multiple-inlines.test
  llvm/test/tools/llvm-tapi-diff/tapi-diff-tbd-has-single-inlineA.test
  llvm/test/tools/llvm-tapi-diff/tapi-diff-tbd-has-single-inlineB.test
  llvm/tools/llvm-tapi-diff/CMakeLists.txt
  llvm/tools/llvm-tapi-diff/DiffEngine.cpp
  llvm/tools/llvm-tapi-diff/DiffEngine.h
  llvm/tools/llvm-tapi-diff/llvm-tapi-diff.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101835.343764.patch
Type: text/x-patch
Size: 60909 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210507/7b8fd955/attachment-0001.bin>