[PATCH] D102076: [lld/mac] Write every weak symbol only once in the output

[Nico Weber via Phabricator via llvm-commits]

thakis marked 2 inline comments as done.
thakis added a comment.

Thanks!



================
Comment at: lld/MachO/InputFiles.cpp:614-615
       nextIsec->data = isec->data.slice(symbolOffset);
+      nextIsec->numRefs = 0;
+      nextIsec->canOmitFromOutput = false;
       isec->data = isec->data.slice(0, symbolOffset);
----------------
gkm wrote:
> These are already specified as initial values in the class declaration.
This is actually a bit subtle: the creation 3 lines up uses the copy ctor, so we do need to reset to the default here. (This is covered by the test.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102076/new/

https://reviews.llvm.org/D102076